[hist] fix regression in AddBinContentND and add test #17573
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferdymercury
commented
Jan 30, 2025
ferdymercury
commented
Jan 30, 2025
Test Results 18 files 18 suites 4d 18h 2m 30s ⏱️ For more details on these failures, see this check. Results for commit c5a1824. |
|
Hi! Sorry I didn't have the time to make the PR myself yet, but I think the best solution is to just add "using TH1::AddBinContent:" to each derived class so that all overloads are accessible |
2 tasks
Thanks, Sure, no problem. I implemented your alternative solution here: #17578 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
This regression broke (my) user code, so if possible try to address this PR before the next release ;)
Fixes #17552
Checklist:
This PR fixes #